Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Message actions (1st iteration) #34133

Merged
merged 10 commits into from
Dec 12, 2024
Merged

refactor: Message actions (1st iteration) #34133

merged 10 commits into from
Dec 12, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Dec 6, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

It removes message actions' initialization from Meteor.startup() callbacks. Additionally, it migrates some actions to idiomatic React components.

Issue(s)

ARCH-1382

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 6, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 59cbfc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (f11efb4) to head (59cbfc4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34133   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34133/
on branch gh-pages at 2024-12-09 19:16 UTC

@tassoevan tassoevan force-pushed the refactor/remaining-message-actions branch 7 times, most recently from 1b61c8f to 9f350d6 Compare December 10, 2024 20:54
@tassoevan tassoevan changed the title refactor: Message actions refactor: Message actions (1st iteration) Dec 11, 2024
@tassoevan tassoevan force-pushed the refactor/remaining-message-actions branch from 2654d5b to 10d90ca Compare December 11, 2024 14:11
@tassoevan tassoevan added this to the 7.2.0 milestone Dec 11, 2024
@tassoevan tassoevan marked this pull request as ready for review December 11, 2024 15:30
@tassoevan tassoevan requested a review from a team as a code owner December 11, 2024 15:30
MartinSchoeler
MartinSchoeler requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some conditions are not being properly verified, when a message is starred, pinned and/or followed, both enable, disable options show

Screenshot 2024-12-11 at 14 30 20

@tassoevan tassoevan force-pushed the refactor/remaining-message-actions branch from 10d90ca to 59cbfc4 Compare December 12, 2024 00:07
@tassoevan tassoevan merged commit 3d41ae2 into develop Dec 12, 2024
49 checks passed
@tassoevan tassoevan deleted the refactor/remaining-message-actions branch December 12, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @MartinSchoeler